sql,colexec: minor cleanup of scan-related things #57267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
approved these changes
Dec 1, 2020
pkg/sql/distsql_physical_planner.go
Outdated
| @@ -1013,8 +1013,8 @@ func tableOrdinal( | |||
| } | |||
| if visibility == execinfra.ScanVisibilityPublicAndNotPublic { | |||
| offset := len(desc.Columns) | |||
| for i, col := range desc.MutationColumns() { | |||
| if col.ID == colID { | |||
| for i := range desc.MutationColumns() { | |||
There was a problem hiding this comment.
extract desc.MutationColumns() outside of the loop, I don't think the compiler can necessarily eliminate the common subexpression here.
pkg/sql/distsql_physical_planner.go
Outdated
| for _, col := range info.desc.MutationColumns() { | ||
| typs = append(typs, col.Type) | ||
| for i := range info.desc.MutationColumns() { | ||
| typs = append(typs, info.desc.MutationColumns()[i].Type) |
pkg/sql/distsql_physical_planner.go
Outdated
| for _, c := range info.desc.MutationColumns() { | ||
| descColumnIDs.Set(colID, int(c.ID)) | ||
| for i := range info.desc.MutationColumns() { | ||
| descColumnIDs.Set(colID, int(info.desc.MutationColumns()[i].ID)) |
This commit removes multiple arguments in favor of using the spec when initializing the cFetcher as well as refactors several loops in order to avoid making copies of descriptors during table reader planning. Additionally, it moves a map from scanNode next to the map's only user (stats job) and removes the map from the scanNode itself as well as removes some of the unused arguments. Release note: None
yuzefovich
commented
Dec 1, 2020
There was a problem hiding this comment.
TFTR!
bors r+
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jordanlewis)
pkg/sql/distsql_physical_planner.go, line 1016 at r1 (raw file):
Previously, jordanlewis (Jordan Lewis) wrote…
extract
desc.MutationColumns()outside of the loop, I don't think the compiler can necessarily eliminate the common subexpression here.
Done.
pkg/sql/distsql_physical_planner.go, line 1288 at r1 (raw file):
Previously, jordanlewis (Jordan Lewis) wrote…
ditto above
Done.
pkg/sql/distsql_physical_planner.go, line 1311 at r1 (raw file):
Previously, jordanlewis (Jordan Lewis) wrote…
ditto above
Done.
craig bot
pushed a commit
that referenced
this pull request
Dec 1, 2020
57267: sql,colexec: minor cleanup of scan-related things r=yuzefovich a=yuzefovich This commit removes multiple arguments in favor of using the spec when initializing the cFetcher as well as refactors several loops in order to avoid making copies of descriptors during table reader planning. Additionally, it moves a map from scanNode next to the map's only user (stats job) and removes the map from the scanNode itself as well as removes some of the unused arguments. Release note: None Co-authored-by: Yahor Yuzefovich <[email protected]>
|
Build failed: |
|
Mysterious test failure with what-looks-like empty logs. bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes multiple arguments in favor of using the spec when
initializing the cFetcher as well as refactors several loops in order to
avoid making copies of descriptors during table reader planning.
Additionally, it moves a map from scanNode next to the map's only user
(stats job) and removes the map from the scanNode itself as well as
removes some of the unused arguments.
Release note: None